ffi: add functions to deal with sliced strings (fix #1909) #1913
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
*_sliced
variants of the following functions that accept an additional length parameter for strings instead of using null-termination:quiche_version_sliced
quiche_enable_debug_logging_sliced
quiche_config_load_cert_chain_from_pem_file_sliced
quiche_config_load_priv_key_from_pem_file_sliced
quiche_config_load_verify_locations_from_file_sliced
quiche_config_load_verify_locations_from_directory_sliced
quiche_config_set_cc_algorithm_name_sliced
quiche_connect_sliced
quiche_conn_set_keylog_path_sliced
quiche_conn_set_qlog_path_sliced
quiche_conn_set_qlog_fd_sliced
This fixes issue #1909.
I'm not very experienced with Rust, so please double-check that I didn't do anything wrong in
ffi.rs
. I'm usingstd::str::from_utf8_unchecked
to create thestr&
in Rust so that there's no runtime overhead for checking UTF-8 validity.