-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logic to create volume from volumecontentsource #39
Conversation
Signed-off-by: hlts2 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, just left a couple of questions 🙏
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We certainly would like to have tests, but cannot test against a commented out code 😆
Thanks, LGTM for now!
@rytswd Thank you for reviewing! I will merge this PR! 🚀 |
WHAT
I have added logic to create volume from volumecontentsource.
WHY
To support volume snapshot, it is necessary to implement functionality to handle case where a user requests the creation of volume from snapshot using a manifest like the one shown below.
FYI