Add CreateSnapshot handler for VolumeSnapshot support #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
hlts2
requested review from
rytswd,
Praveen005,
chadmcrowell and
RealHarshThakur
…Error Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
rytswd
approved these changes
Dec 10, 2024
pkg/driver/controller_server.go
Outdated
Comment on lines
606
to
607
| // snapshotName := req.GetName() | ||
| // sourceVolID := req.GetSourceVolumeId() |
There was a problem hiding this comment.
I think this line can move further up even before the log line, and reuse the variable snapshotName and sourceVolID everywhere, rather than calling req.GetName() multiple times
There was a problem hiding this comment.
Thank you for catching it! After I fix it, I will merge this PR! 🚀
Signed-off-by: hlts2 <[email protected]>
|
@rytswd Thank you for your review! I will merge this PR 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
@Praveen005 have implemented CreateSnapshot handler.
This PR is mirror of #31
CreateSnapshot handler was previously developed as a forked repository, but the CI wasn't working due to a credential issue. Therefore, I temporarily created a new PR. I will fix the credential issue in a separate PR in the future. Sorry 🙏
Base code is cherry-picked from forked PR, so code author is not changed.
WHY
We plan to add support for VolumeSnapshot in the civo-csi driver.
To achieve this, we need to implement the following handlers.
FYI