Reduce time complexity by modifying the data structure #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Modified the data structure to reduce the time complexity of the access mode existence check for volumes during RPC calls. This enables existence checks to be performed in O(1) time.
WHY
A loop was used each time to check if there was a matching access mode for Volume. Currently, the loop only runs twice, so it's not an issue, but optimizing to O(1) check is better in case the number of access modes for Volume increases in the future.
Below is a list of possible options.
FYI
This PR includes only changes to the data structure, so no logic modifications have been made 🙏
Additionally, the
supportedAccessModes
variable was not used anywhere outside ofpkg/driver/controller_server.go
, so there were no changes made in other areas.The following is the test result.