[REF] - Simplify redundant calls to empty() function
#32043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
The `empty()` function will automatically handle the case where the first part of the expression is not set, so there's no need to add an extra call to `empty()`.
|
@civicrm-builder retest this please |
| @@ -112,7 +112,7 @@ public static function getTypeAttributes(SimpleXMLElement $fieldXML) { | |||
| */ | |||
| public static function getSize(SimpleXMLElement $fieldXML): string { | |||
| // Extract from <size> tag if supplied | |||
| if (!empty($fieldXML->html) && !empty($fieldXML->html->size)) { | |||
| if (!empty($fieldXML->html->size)) { | |||
There was a problem hiding this comment.
wouldn't this one still get upset?
| @@ -39,7 +39,7 @@ public function __construct($title = NULL, $action = CRM_Core_Action::NONE, $mod | |||
| if ($mid && $continue) { | |||
| //CRM-15979 - check if abtest exist for mailing then redirect accordingly | |||
| $abtest = CRM_Mailing_BAO_MailingAB::getABTest($mid); | |||
| if (!empty($abtest) && !empty($abtest->id)) { | |||
| if (!empty($abtest->id)) { | |||
There was a problem hiding this comment.
I feel like this would upset php 8.x if $abtest is null
|
@eileenmcnaughton I did a little more research and reports are mixed about how safe this change would be. Better leave it alone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Overly-verbose code cleanup.
Technical Details
The
empty()function will automatically handle the case where the first part of the expression is not set, so there's no need to add an extra call toempty().