-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[do not merge] civi-tabset js component #32038
Draft
ufundo
wants to merge
11
commits into
civicrm:master
Choose a base branch
from
ufundo:civi-tabset-both
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same functionality, but a bit more clear what's going on
Allows a tabset element to be configured in FormBuilder
This was a challenge! I had to rework the afTabset & afTab components, because there's no good way to access properties of a controller in transcluded html. Using transclude and then accessing `$parent.count` worked, but I'm not sure why. Angular scope is dark magic...
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
Weird - I can't access CiviCampaign on the test site. The extension is enabled but not showing in Navigation and if I use direct link http://core-32038-7povl.test-1.civicrm.org:8003/civicrm/campaign?reset=1 I get access denied 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Attempt to add a WebComponent tab implementation that can be used in Smarty AND Angular, without any jQuery dependencies.
Comments
It's not working. I've mainly looked at the contact summary, manage events page, and the Campaign Dashboard as updated in #31944
Things that seem to work:
total=count="'civi-tabset'"
routeThings that def don't work yet:
Technical Details
The tab implementation was originally inspired by https://daverupert.com/2021/10/native-html-tabs/
The aim is to be as-close-as-possible to native HTML markup - ie like
<details><summary>
but for tabs. In practice this is complicated by more complex stuff we have around tabs like counts, and lazy loaded ajax content. (The latter was done with a second new component, "civi-snippet
")The idea behind using
in the markup is to degrades gracefully. If the JS doesn't load you will still get a basically navigable page (with collapsibles for each tab).