Fix illogical ignore/skip duplicates handling

[eileenmcnaughton]

Overview

The code for importing duplicates offers the option to 'skip' or 'ignore' duplicate contact handling

The help text is messed up for this - but the screen & code imply the expectation is

1. if skip is selected & the contact already has a registration for that event then skip as a duplicate
2. if ignore is selected the contact gets a second duplicate.

However, the code doesn't actually do this

Before

The code that kicks in for "skip" relies on
if (is_array($newParticipant) && civicrm_error($newParticipant)) {

• However, this is only ever true if $newParticipant is set in the isIgnoreDuplicates() if clause. Conversely if isIgnoreDuplicates is true the code never attempts to import the contact

After

I concluded the if that looks up the existing registrations was mistakenly set to isIgnoreDuplicates() and should have been isSkipDuplicates()

Technical Details

I didn't do additional clean up to not add further confusion but the whole error routine is batshit

Comments

\

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[eileenmcnaughton]

@stesi561 no good deed ever goes unpunished - I see you looked at another PR so wondering if you could take a look & check my thinking /logic here

[stesi561]

I saw this and it hurt my brain too much.

[stesi561]

I'm now subscribed so will try and look at it later. This is some interesting behaviour to be sure!