Standalone login box coloring - fix the text color to black to fix dark mode #31991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix dev/core#5722 Use smarty variable which is a boolean instead of the token which is localized
Now that the last 2 domain-specific option groups have been dealt with: - civicrm#31909 - civicrm#31924 ... we can stop using this godawful is_domain column for good. The OptionValue table is complex enough without it!
…value This does the same thing as before, in one much simpler line.
dev/core#5722 AdminUI - Fix Manage ACLs mode column
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
ufundo
force-pushed
the
standalone-login-box-color-fix
branch
from
0b63284 to
43ace48
Compare
|
Noticed the "Forgot password" link is also struggling a bit in dark mode. I've fixed it to grey similarly now. edit: amended again to slightly darker grey for AAA contrast rating :) |
ufundo
force-pushed
the
standalone-login-box-color-fix
branch
from
43ace48 to
1b7a780
Compare
UtilsArray - Refactor out uses of deprecated CRM_Utils_Array::value
Import code consolidation, membership import
|
Would some of these problems be solved if we had a dark-mode version of the Civi logo? ie white text and white border around the triangles? Then the login box can have a dark bg and the theme then can just do its stuff? |
Add guard around CIVICRM_IFRAME constant
OptionGroup - Deprecate isDomainOptionGroup function
Decommission thresholdQuery, only call legacy hook from backward compat extension
[REF] Use tokenProcessor to render display name
dev/financial#230 - don't send email receipt when changing payment method on a contribution
dev/core#5578 Adding Recurring tokens to Contribution/Membership toke…
6.0 to master
Remove "Cleanup Caches and Update Paths" page, leave a Clear Caches button and deprecate update/reset paths
Deprecate legacy parameters to Address::format()
Ensure modelProps has contributionID
[REF] Member/Pledge - Refactor out uses of deprecated CRM_Utils_Array::value
Merge 6.0 to master
Ensure contributionSummary is assigned to the template and check if it is empty
Update tplanner/when for type hints
|
Have added a PR to RL for this: #32079 |
Fix notices when rendering advanced search as contributions
dev/core#4923 CustomField - Don't index disabled fields
Extract part of function that is shared between old path & new
ufundo
force-pushed
the
standalone-login-box-color-fix
branch
from
1b7a780 to
edf4b3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix disappearing labels on the login box with Riverlea dark mode.
Before
Light mode ✔️
Dark mode labels disappear 🌑 😞
After
Fix the text color in that box to black.
Light mode (label text is very slightly darker than the default --crm-c-text in this stream):
Dark mode good:
(all screenshots using Hackney Brook. Similar story on Minetta and Walbrook. Thames overrides to a dark background color in dark mode, this PR adds forcing text back to white at the same time)
Comments
I don't know how I feel about fixing on specific colors here, but a) it is simplest fix I can think of; b) given we have the Civi logo in this box, which has fixed colors, then that sort of dictates the background color; c) if we are setting a background color, I think we should set a text color that goes with it; d) if themes want to override they can (as Thames is doing)
There is a slight issue in the screenshot above that the change leaks into the alert box text. That seems to be because of a separate issue with an undefined variable specifically in Hackney Brook, I will make a separate PR for that.
cc @vingle @artfulrobot