Finder ext again #31967
Open
Finder ext again #31967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
===== Overview ==== This adds a new extension for existing dedupe finder behaviour, allowing us to support the hook that is jammed in the middle of the dedupe finder code going forwards without being blocked by it (I have an existing PR that cuts many hours off the dedupe query but it is bending over backwards to work alongside the legacy attempts to allow integration). The new extension is enabled on install and on upgrade and there is no behaviour change unless a site admin disables it. If they choose to do so then 1) the legacy hook & legacy reserved query wrangling will no longer be called 2) dedupe queries will speed up once the blocked code is also merged civicrm#30591
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
eileenmcnaughton
force-pushed
the
finder_ext_again
branch
from
d9c12ed to
b81817c
Compare
colemanw
reviewed
Feb 5, 2025
|
|
||
| class Finder { | ||
| class Finder extends AutoSubscriber implements EventSubscriberInterface { |
There was a problem hiding this comment.
FYI AutoSubscriber already implements EventSubscriberInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Still trying on #31959
WARNING: Class Civi\LegacyFinder\Finder was expected to have a service definition, but it did not. Perhaps it needs service name.
This didn't get picked up either (after a
cv flush)+++ b/ext/legacydedupefinder/Civi/LegacyFinder/Finder.php
@@ -3,10 +3,10 @@
namespace Civi\LegacyFinder;
use Civi\Core\Event\GenericHookEvent;
-use Civi\Core\Service\AutoService;
+use Civi\Core\Service\AutoSubscriber;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
-class Finder extends AutoService implements EventSubscriberInterface {
+class Finder extends AutoSubscriber implements EventSubscriberInterface {
Before
What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.
After
What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.
Technical Details
If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.
Comments
Anything else you would like the reviewer to note