Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standalone password reset email template #31850

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Standalone password reset email template #31850

wants to merge 1 commit into from

Conversation

artfulrobot
Copy link
Contributor

@artfulrobot artfulrobot commented Jan 21, 2025 •
edited
Loading

  • corrects grammar due to wrongly back-slashed apostrophes.
  • makes the createPasswordResetMessageTemplate public, which may enable its use from elsewhere.

Further improvements for future PRs:

  • use a mgd file? But avoid duplicating the content somehow?
  • check for the existence before creating (like ->match('name') except that it's more complex than that.

See related https://lab.civicrm.org/extensions/standalonemigrate/-/merge_requests/9

@civibot civibot
Copy link

civibot bot commented Jan 21, 2025

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Jan 21, 2025
@artfulrobot artfulrobot mentioned this pull request Jan 21, 2025
Merged
ufundo
ufundo reviewed Jan 23, 2025
View reviewed changes
ext/standaloneusers/CRM/Standaloneusers/Upgrader.php

{\$resetUrlPlaintext}

{ts}This link expires one hour after the date of this email.{/ts}
Copy link
Contributor

@ufundo ufundo Jan 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the timeout is now parameterised, so would be good to tokenise if we can

@ufundo
Copy link
Contributor

ufundo commented Jan 23, 2025

use a mgd file? But avoid duplicating the content somehow?

That was my hope, though I need to learn how Message Templates work...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ufundo ufundo ufundo left review comments

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artfulrobot @ufundo