-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCIP-014: Upgrade to pox-3 #14
Conversation
1. Set minting contract for Mia and nyc to a version using pox 2 2. add treasury that uses the minting contract from 1 3. Transfer stx to treasury of 2. 4. Set pool address 5. Delegate stx to pool 6. Pay stackers that were not paid in cycle 56 due to bug Please see more details here: citycoins#13 and kindly suggest edits to this first draft.
Hey @Rapha-btc - thanks for getting this started! Based on the discussions in Discord I think we should separate our intentions into three SIPs:
With this the first would be scoped to the changes we need now in line with pox-3. The second would represent the voting method where we can document it's usage across different proposals, as well as replace it with a future method using the same CCIP process. The third would be the place to store calculations and related proofs for claims, where we can try to use on-chain data where possible ( Given that structure let's start filling in this draft with the information we have for the pox-3 upgrade. An easy way to start is to copy all the headings from CCIP-000, and we can fill them in as the implementation progresses. |
Actually, looking closer at the PR, instead of attaching the markdown in the text file to your comment you should include the code as part of your changes. You can do that by renaming the file Then it will show the code line-by-line and display it correctly on GitHub for the PR. There are also a few spots where pox-2 should be updated to pox-3 as well. Let me know if you have any questions! |
Thanks for your kind guidelines. Looking forward to review code edits and continue to learn! |
FYI - going to add some commits to keep this moving along, and contracts are still being tracked in this PR. |
The four contracts deployed were:
In addition to that, a trait representing CCIP-015 was deployed and used, and is available for future proposals that include a vote. The contract for
Following that, ccip-014-pox-3-v2 was deployed and executed after checking the (define-read-only (is-executable)
(contract-call? .ccip014-pox-3 is-executable)
)
Yes, per the CCIP-015 draft spec and using the trait listed above (first implementation). Any proposal can do the same, and a new method could be defined by a new CCIP should we need it.
Linked the deployed contracts in my comments above. 🙂 |
This is ready to merge! Congrats everyone for making it happen, and @Rapha-btc for kicking off the efforts! |
CCIP-014
Preamble
Summary
Please kindly suggest edits to this first draft.