Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
package/check: fix compile issue due to missing source file
The release tarball of check 0.15.2 lacks a source file, causing a build failure, as reported at libcheck/check#303. This failures happens when thread support is not available, as the file missing is getting compiled in when thread support is not there: if(NOT HAVE_PTHREAD) target_sources(check PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/../lib/pthread_mutex.c) target_sources(checkShared PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/../lib/pthread_mutex.c) endif() This issue started appearing when we moved from the autotools build system to the CMake build system in commit 6dfc789. One might wonder why changing the build system can cause this kind of issue: the file was in fact already missing. Turns out that the missing file is never used with the autotools build system: this file provides some Win32 compatibility layer for pthread functions, so the autotools build system never compiled this file as the autotools build system was only used on Unix platforms. With CMake it now gets compiled to support Windows platform. But on Linux, the entire contents of the file is ignored as it is within a HAVE_WIN32_INIT_ONCE ifdef...endif. Still, with the file missing, the build fails. Until upstream publishes a new release with a complete tarball, switch to fetching the Github-generated tarball, which does contain the missing file. Fixes: http://autobuild.buildroot.net/results/b1087e9a67ff0382632b73f280fabe92cd863593/ Signed-off-by: Waldemar Brodkorb <[email protected]> Signed-off-by: Thomas Petazzoni <[email protected]>
- Loading branch information