Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused clear cache workflow #1472

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

james-garriss
Copy link
Collaborator

@james-garriss james-garriss commented Dec 16, 2024

🗣 Description

My original intention was to move the code in the clear cache workflow into a function and write Pester tests for it, all as part of epic #1402. Then I realized that this workflow is not being used at all. I have decided to remove this workflow instead, and for the moment I put the code into the repo wiki, in case it's ever needed again.

https://github.com/cisagov/ScubaGear/wiki/Clear-Cache-Workflow

💭 Motivation and context

Closes: #1451

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • Related issues these changes resolve are linked preferably via [closing keywords]
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.
  • Feature branch has been rebased against changes from parent branch, as needed
  • Resolved all merge conflicts on branch
  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@james-garriss james-garriss added the enhancement This issue or pull request will add new or improve existing functionality label Dec 16, 2024
@james-garriss james-garriss added this to the Lionfish milestone Dec 16, 2024
@james-garriss james-garriss self-assigned this Dec 16, 2024
@james-garriss james-garriss force-pushed the 1451-write-unit-tests-for-clear-caches branch from 363500c to 195f4ce Compare December 19, 2024 19:17
@james-garriss james-garriss marked this pull request as ready for review December 19, 2024 19:29
Copy link
Collaborator

@schrolla schrolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and found no references to the given workflow. So all for removing it.

Copy link
Collaborator

@dagarwal-mitre dagarwal-mitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find any references and checked the wiki to make sure code is there, looks good.

@james-garriss
Copy link
Collaborator Author

@nanda-katikaneni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write unit tests for clear caches
3 participants