gateway-api: Add required labels and annotations #33990
Merged
+106
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
sayboras
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/ci-gateway-api |
|
/test |
sayboras
added
the
needs-backport/1.16
mhofstetter
reviewed
Jul 24, 2024
1 task
sayboras
force-pushed
the
pr/tammach/gateway-api-label
branch
from
3b487db to
562c74b
Compare
|
/ci-gateway-api |
mhofstetter
reviewed
Aug 6, 2024
|
/ci-gateway-api |
sayboras
force-pushed
the
pr/tammach/gateway-api-label
branch
from
5211499 to
50b77da
Compare
This commit is to add the required label gateway-name e.g. `gateway.networking.k8s.io/gateway-name`, and propagate all labels and annotations from spec.infrastructure in all generated resources. The main goal is to conform with below GEP. Relates: kubernetes-sigs/gateway-api#1757 Signed-off-by: Tam Mach <[email protected]>
This test is not supported in standard channel, hence we need to add to the exclude list. Signed-off-by: Tam Mach <[email protected]>
sayboras
force-pushed
the
pr/tammach/gateway-api-label
branch
from
50b77da to
074321d
Compare
|
/ci-gateway-api |
|
/ci-integration |
|
/test |
tklauser
approved these changes
Aug 6, 2024
mhofstetter
approved these changes
Aug 6, 2024
sayboras
added
backport-pending/1.16
github-actions
bot
added
backport-done/1.16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is to add the required label gateway-name e.g.
gateway.networking.k8s.io/gateway-name, and propagate all labels and annotations from spec.infrastructure in all generated resources. The main goal is to conform with below GEP.Relates: kubernetes-sigs/gateway-api#1757