chore: simplify strings for expand/collapse

chrisgurney · Oct 14, 2024 · acef51e · acef51e
1 parent 9e495ed
commit acef51e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/src/I18n/en.json b/src/I18n/en.json
@@ -69,8 +69,10 @@
     },
     "setting": {
         "button-cancel": "Cancel",
+        "button-collapse-tooltip": "Collapse section",
         "button-delete-tooltip": "Delete",
         "button-drag-tooltip": "Drag to rearrange",
+        "button-expand-tooltip": "Expand section",
         "button-help": "Help",
         "button-help-tooltip": "Open the help window",
         "button-learn-more": "Learn\u00A0more",
@@ -204,8 +206,6 @@
             "label-empty-no-items": "No toolbar items.",
             "button-add-break-tooltip": "Add a line break to the toolbar",
             "button-add-separator-tooltip": "Add a separator to the toolbar",
-            "button-collapse-items-tooltip": "Collapse all items",
-            "button-expand-items-tooltip": "Expand all items",
             "button-new-item": "+ Add toolbar item",
             "button-new-item-tooltip": "Add a new item to the toolbar",
             "option-item-empty-label": "No label set",
@@ -311,10 +311,8 @@
             "name": "Toolbars",
             "name-with-count": "Toolbars ({{count}})",
             "description": "Define the toolbars you want to add to your notes.",
-            "button-collapse-tbars-tooltip": "Collapse all toolbars",
             "button-duplicate-tbar-tooltip": "Duplicate",
             "button-edit-tbar": "Edit",
-            "button-expand-tbars-tooltip": "Expand all toolbars",
             "button-edit-tbar-tooltip": "Update this toolbar",
             "button-more-tooltip": "More options",
             "button-new-tbar": "+ New toolbar",

diff --git a/src/Settings/UI/Modals/ToolbarSettingsModal.ts b/src/Settings/UI/Modals/ToolbarSettingsModal.ts
@@ -216,15 +216,15 @@ export default class ToolbarSettingsModal extends Modal {
 			itemsSetting
 				.addExtraButton((cb) => {
 					cb.setIcon('right-triangle')
-					.setTooltip(t('setting.items.button-collapse-items-tooltip'))
+					.setTooltip(t('setting.button-collapse-tooltip'))
 					.onClick(async () => {
 						let itemsContainer = settingsDiv.querySelector('.note-toolbar-setting-items-container');
 						if (itemsContainer) {
 							this.itemListOpen = !this.itemListOpen;
 							itemsContainer.setAttribute(SettingsAttr.Active, this.itemListOpen.toString());
 							let heading = itemsContainer.querySelector('.setting-item-heading .setting-item-name');
 							this.itemListOpen ? heading?.setText(t('setting.items.name')) : heading?.setText(t('setting.items.name-with-count', { count: this.toolbar.items.length }));
-							cb.setTooltip(this.itemListOpen ? t('setting.items.button-collapse-items-tooltip') : t('setting.items.button-expand-items-tooltip'));
+							cb.setTooltip(this.itemListOpen ? t('setting.button-collapse-tooltip') : t('setting.button-expand-tooltip'));
 						}
 					})
 					.extraSettingsEl.tabIndex = 0;

diff --git a/src/Settings/UI/NoteToolbarSettingTab.ts b/src/Settings/UI/NoteToolbarSettingTab.ts
@@ -150,15 +150,15 @@ export class NoteToolbarSettingTab extends PluginSettingTab {
 			toolbarListSetting
 				.addExtraButton((cb) => {
 					cb.setIcon('right-triangle')
-					.setTooltip(t('setting.toolbars.button-collapse-tbars-tooltip'))
+					.setTooltip(t('setting.button-collapse-tooltip'))
 					.onClick(async () => {
 						let itemsContainer = containerEl.querySelector('.note-toolbar-setting-items-container');
 						if (itemsContainer) {
 							this.itemListOpen = !this.itemListOpen;
 							itemsContainer.setAttribute('data-active', this.itemListOpen.toString());
 							let heading = itemsContainer.querySelector('.setting-item-info .setting-item-name');
 							this.itemListOpen ? heading?.setText(t('setting.toolbars.name')) : heading?.setText(t('setting.toolbars.name-with-count', { count: this.plugin.settings.toolbars.length }));
-							cb.setTooltip(this.itemListOpen ? t('setting.toolbars.button-collapse-tbars-tooltip') : t('setting.toolbars.button-expand-tbars-tooltip'));
+							cb.setTooltip(this.itemListOpen ? t('setting.button-collapse-tooltip') : t('setting.button-expand-tooltip'));
 						}
 					})
 					.extraSettingsEl.tabIndex = 0;
@@ -357,15 +357,15 @@ export class NoteToolbarSettingTab extends PluginSettingTab {
 			toolbarMapSetting
 				.addExtraButton((cb) => {
 					cb.setIcon('right-triangle')
-					.setTooltip("Collapse all mappings")
+					.setTooltip(t('setting.button-collapse-tooltip'))
 					.onClick(async () => {
 						let mappingsContainer = containerEl.querySelector('.note-toolbar-setting-mappings-container');
 						if (mappingsContainer) {
 							this.mappingListOpen = !this.mappingListOpen;
 							mappingsContainer.setAttribute('data-active', this.mappingListOpen.toString());
 							let heading = mappingsContainer.querySelector('.setting-item-info .setting-item-name');
 							this.mappingListOpen ? heading?.setText(t('setting.mappings.name')) : heading?.setText(t('setting.mappings.name-with-count', { count: this.plugin.settings.folderMappings.length }));
-							cb.setTooltip(this.mappingListOpen ? t('setting.mappings.button-collapse-tooltip') : t('setting.mappings.button-expand-tooltip'));
+							cb.setTooltip(this.mappingListOpen ? t('setting.button-collapse-tooltip') : t('setting.button-expand-tooltip'));
 						}
 					})
 					.extraSettingsEl.tabIndex = 0;