Check if Shamiko whitelist is not active before configuring DenyList #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since creating a file named 'whitelist' on /data/adb/shamiko/ seems to be the only way to enable whitelist mode on Shamiko. This commit adds a simple if statement to check that whitelist mode is not enabled.
|
Thanks ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since creating a file named
whiteliston/data/adb/shamiko/seems to be the only way to enable whitelist mode on Shamiko, and a lot of people are complaining about this.This PR adds a single if statement to check that whitelist mode is not enabled, before adding
com.google.android.gmsandcom.google.android.gms.unstableto DenyList.