Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hardware debug ROB #3560

Merged
merged 7 commits into from
Jan 29, 2024
Merged

Add hardware debug ROB #3560

merged 7 commits into from
Jan 29, 2024

Conversation

joonho3020
Copy link
Contributor

Related issue:

Type of change: bug report | feature request | other enhancement

Impact: no functional change | API addition (no impact on existing code) | API modification

Development Phase: proposal | implementation

Release Notes

@joonho3020 joonho3020 requested a review from jerryz123 January 20, 2024 21:24
@mergify mergify bot mentioned this pull request Jan 20, 2024
Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joey0320 we want to be able to remove the debugrob where necessary, please add that support to the WithRocketDebugROB.

@jerryz123
Copy link
Contributor

Please update the title of this PR so that the merge commit will convey more useful information.
Then after @sequencer approves, we can merge

@joonho3020 joonho3020 changed the title Trace wb dev Add hardware debug ROB Jan 26, 2024
@jerryz123 jerryz123 requested a review from sequencer January 27, 2024 08:44
Copy link
Member

@sequencer sequencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, In the future, I'd like to migrate it to layer API for splitting RTL and verification codes

@jerryz123 jerryz123 merged commit baa9f45 into chipsalliance:dev Jan 29, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants