Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AXI4 Xbar elaboration error due to missing fields #3549

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

tymcauley
Copy link
Contributor

Related issue: #3548

Type of change: bug report

Impact: no functional change

Development Phase: implementation

Release Notes

Copy link

linux-foundation-easycla bot commented Dec 24, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: tymcauley / name: Tynan McAuley (2a3bd4e)

Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this PR on dev?

@tymcauley tymcauley changed the base branch from master to dev December 24, 2023 21:43
@tymcauley
Copy link
Contributor Author

Unfortunately I need to wait a bit to get some feedback from my company on the CLA, so resolving that is going to take some time.

@tymcauley
Copy link
Contributor Author

On a recent firtool version (1.58.0), I found that I'm getting this error:

generators/rocket-chip/src/main/scala/amba/axi4/Xbar.scala:86:18: error: sink "in_1_w_bits_user_corrupt" not fully initialized in "AXI4Xbar"

I worked around it by adding this line right above the in(i).squeezeAll.waiveAll :<>= io_in(i).squeezeAll.waiveAll statement:

in(i).w.bits.user := DontCare

Not completely sure what the more principled way to solve this is, but I do see that tilelink/Xbar.scala also tying off some the user signals. Presumably we want user signals to propagate through the crossbar when appropriate.

@tymcauley
Copy link
Contributor Author

Okay, I believe I've taken care of all the fields that need to be tied off in case they're not used by a particular destination.

@tymcauley
Copy link
Contributor Author

Checking on the status of this, anything else that I need to do before this can be merged @jerryz123 ?

Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this just slipped past me. Let's merge this

@jerryz123 jerryz123 merged commit 49e7d27 into chipsalliance:dev Feb 20, 2024
26 checks passed
@tymcauley
Copy link
Contributor Author

Nope, this just slipped past me. Let's merge this

Thanks so much!

@tymcauley tymcauley deleted the waiveall-axi4-xbar branch February 20, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants