SContext is remaps to HContext when in VSMode #3546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by the manuals. * Fix the mapping when we access scontext or hcontext to ensure we don't switch targets. * Add comment to indicate why we are mapping the S to VS and VS to S.
JulianBailey
changed the title
ingallsj
approved these changes
Dec 18, 2023
jerryz123
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Type of change: bug report
Impact: functional fix
Development Phase: implementation
Release Notes
The previous code would have remapped
SContexton toHContextwhen in VSMode. This is an error, unfortunately HContext was assigned the address that may have been given toVSContextif added in the future. The adjusted code will no longer map this incorrectly.