Remove Scalar Crypto and BitManip #3532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems to be a sad story to add and remove a feature. |
|
I am concerned about whether we should remove BarrelShifter.scala and SBox.scala as they can be used in many projects. |
|
Just let it go. |
jerryz123
approved these changes
Nov 16, 2023
|
@Mergifyio copy master |
✅ Pull request copies have been created
|
jerryz123
added a commit
that referenced
this pull request
Nov 25, 2023
Remove Scalar Crypto and BitManip (copy #3532)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #3529
Type of change: feature request
Impact: API modification
Development Phase: implementation
Release Notes
Remove Scalar Crypto and BitManip as discussed in #3529