HasTilesModuleImp should not extends HasPeripheryDebugModuleImp #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sequencer
force-pushed
the
HasTilesModuleImp_fix
branch
from
d52ad7c to
f2fc1e6
Compare
sequencer
force-pushed
the
HasTilesModuleImp_fix
branch
from
f2fc1e6 to
e568b41
Compare
sequencer
commented
Feb 27, 2023
Comment on lines
+76
to
+83
| lazy val debugCustomXbarOpt = p(DebugModuleKey).map(params => LazyModule( new DebugCustomXbar(outputRequiresInput = false))) | ||
| lazy val apbDebugNodeOpt = p(ExportDebug).apb.option(APBMasterNode(Seq(APBMasterPortParameters(Seq(APBMasterParameters("debugAPB")))))) | ||
| val debugTLDomainOpt = p(DebugModuleKey).map { _ => | ||
| val domain = ClockSinkNode(Seq(ClockSinkParameters())) | ||
| domain := tlbus.fixedClockNode | ||
| domain | ||
| } | ||
| val debugOpt = p(DebugModuleKey).map { params => | ||
| lazy val debugOpt = p(DebugModuleKey).map { params => |
There was a problem hiding this comment.
These lazy is necessary for avoid null pointer issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm beaten by current debug io connections, and decide to get rid of
HasPeripheryDebugModuleImpand instantiate our own version. However I just noticed, theHasTilesalso extendsHasPeripheryDebugModuleImp......This PR simply remove
HasPeripheryDebugModuleImpfromHasTiles.Related issue:
Type of change: bug report | feature request | other enhancement
Impact: no functional change | API addition (no impact on existing code) | API modification
Development Phase: proposal | implementation
Release Notes