Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare MLDSA signature digest to save on ROM size. #1965

Merged
merged 4 commits into from
Feb 19, 2025
Merged

Compare MLDSA signature digest to save on ROM size. #1965

merged 4 commits into from
Feb 19, 2025

Conversation

mtimkovich
Copy link

No description provided.

@mtimkovich mtimkovich added the Caliptra v2.0 Items to be considered for v2.0 Release label Feb 14, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Feb 14, 2025 •
edited
Loading

CLA Not Signed

jhand2
jhand2 previously approved these changes Feb 14, 2025
View reviewed changes
swenson
swenson previously approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It looks like you should be able to also do the public and private key as well.

mhatrevi
mhatrevi reviewed Feb 14, 2025
View reviewed changes
kat/src/mldsa87_kat.rs Outdated Show resolved Hide resolved
@mtimkovich mtimkovich dismissed stale reviews from swenson and jhand2 via 33b6b14 February 18, 2025 21:31
@mtimkovich mtimkovich force-pushed the mtimkovich/mldsa-kat-sha branch from b9a30de to 33b6b14 Compare February 18, 2025 21:31
@mtimkovich mtimkovich force-pushed the mtimkovich/mldsa-kat-sha branch from f2f13eb to bf65389 Compare February 19, 2025 19:21
swenson
swenson approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhatrevi mhatrevi merged commit ce626a3 into main-2.x Feb 19, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swenson swenson swenson approved these changes

@mhatrevi mhatrevi mhatrevi approved these changes

@jhand2 jhand2 jhand2 left review comments

@ajisaxena ajisaxena Awaiting requested review from ajisaxena ajisaxena is a code owner

@vsonims vsonims Awaiting requested review from vsonims vsonims is a code owner

@korran korran Awaiting requested review from korran korran is a code owner

@JohnTraverAmd JohnTraverAmd Awaiting requested review from JohnTraverAmd JohnTraverAmd is a code owner

Assignees
No one assigned
Labels
Caliptra v2.0 Items to be considered for v2.0 Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtimkovich @swenson @jhand2 @mhatrevi