Make the libcaliptra test verify LMS signatures by default. #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhalvorsen
requested review from
fdamato,
wmaroneAMD,
JohnTraverAmd,
jlmahowa-amd,
korran,
mhatrevi,
swenson,
vsonims and
nquarton
as code owners
jhand2
approved these changes
Jan 31, 2025
Previously LMS signatures were ignored. This enables `lms_verify` in the fuse register by default. It can be skipped by defining an environment variable. For example: ``` SKIP_LMS_VERIFY=1 make run ```
jhand2
force-pushed
the
zhalvorsen-lms-verify
branch
from
2eb9d2e to
5dce932
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously LMS signatures were ignored. This enables
lms_verifyin the fuse register by default. It can be skipped by defining an environment variable. For example: