[runtime] Start recovery flow in the runtime #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swenson
requested review from
jhand2,
fdamato,
rusty1968,
bluegate010,
mhatrevi,
vsonims,
ajisaxena,
korran and
JohnTraverAmd
as code owners
swenson
commented
Jan 23, 2025
swenson
force-pushed
the
download-manifest-mcu-fw
branch
2 times, most recently
from
9152e52 to
c9b226d
Compare
swenson
requested review from
jlmahowa-amd,
wmaroneAMD and
nquarton
as code owners
mhatrevi
reviewed
Jan 28, 2025
mhatrevi
reviewed
Jan 28, 2025
mhatrevi
previously approved these changes
Jan 28, 2025
jhand2
reviewed
Jan 28, 2025
mhatrevi
reviewed
Jan 29, 2025
swenson
force-pushed
the
download-manifest-mcu-fw
branch
from
0eade71 to
c56a00d
Compare
|
PR updated and rebased. PTAL |
swenson
force-pushed
the
download-manifest-mcu-fw
branch
from
c56a00d to
029bf2a
Compare
This stubs out the recovery flow in the runtime. We also update the DMA peripheral so that it can be used as a `ureg::Mmio`, which will allow us to use the autogenerated I3C recovery register interface instead of hardcoding offsets. We also had to modify `ureg` slightly to remove the unused `impl Uint` for `u64` (because we don't don't support 64-bit AXI transfers) and add a `from_u32()` method for the (unused) `u8` and `u16` implementations. This builds on #1867 and rewrites it to use the updated DMA interface.
swenson
force-pushed
the
download-manifest-mcu-fw
branch
from
029bf2a to
020f2a3
Compare
To account for the offset inside the I3C registers. Otherwise the AXI address is off by 0x100. Also sets the PROT_CAP registers to their required values in the emulator.
mhatrevi
reviewed
Feb 5, 2025
mhatrevi
previously approved these changes
Feb 5, 2025
…aliptra-sw into download-manifest-mcu-fw
mhatrevi
approved these changes
Feb 5, 2025
|
Thanks! |
ArthurHeymans
added a commit
that referenced
this pull request
Feb 7, 2025
The code used to be like this but the rework of #1904 changed that again. The RDL does not specify the semantics of the registers yet and the weird multi dword semantics comes from an old version of OCP I3C commands, which likely don't translate to how the hardware really works. Signed-off-by: Arthur Heymans <[email protected]>
mhatrevi
pushed a commit
that referenced
this pull request
Feb 8, 2025
* Add active mode to model_emulated * fix: don't complete mailbox transaction twice The caller of process_mailbox_commands() does this already. Doing it twice results in update reset flow being broken. * feat: add unit tests for rom with active mode * Fix up image size like the emulator The code used to be like this but the rework of #1904 changed that again. The RDL does not specify the semantics of the registers yet and the weird multi dword semantics comes from an old version of OCP I3C commands, which likely don't translate to how the hardware really works. * sw-emulator: Use exact addr and only set bits Don't set the whole status0 bit and use the full address for the RRI status and not the lowest bits as that could conflict with other registers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stubs out the recovery flow in the runtime.
We also update the DMA peripheral so that it can be used as a
ureg::Mmio, which will allow us to use the autogenerated I3C recoveryregister interface instead of hardcoding offsets.
We also had to modify
uregslightly to addDefault,TryFrom<u32>,and
TryInto<u32>constraints toUintto make it simpler to use with theDMA interface.
This builds on #1867 and rewrites it to use the updated DMA interface.