-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fuse_ctrl] Generate partitions mmap #47
base: main
Are you sure you want to change the base?
[fuse_ctrl] Generate partitions mmap #47
Conversation
|
40ddc68
to
24e06ae
Compare
24e06ae
to
4f45f29
Compare
4f45f29
to
e3e50ae
Compare
{ | ||
name: "FIELD_ENTROPY_0", | ||
inv_default: "<random>", | ||
size: "8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we inline the documentation for each field? You can probably use desc:
variables. The documentation should match the Caliptra spec.
variant: "Unbuffered", | ||
size: "64", // in bytes | ||
absorb: true, | ||
secret: false, | ||
sw_digest: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anjpar @ekarabu, when a partition is set to sw_digest: true
, I believe there is no hardware digest checking taking place. We should document in the guidelines that the ROM is expected to check the digest before consuming the values.
Alternatively, you may want to add a hash digest field to this partition so that ROM can compare the hash after loading the data into SRAM. If you opt for the hash approach, you can use either SHA256 or SHA384.
This is a defense in depth recommendation. Without this, we are relying on the OTP ECC integrity checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment also applies to other SW OTP partitions that contain critical values.
Another option I forgot to mention is that you can use multibit encodings for critical fields. If all fields are hardened, then the digest check becomes optional.
name: "UDS_SEED", | ||
size: "48" | ||
} | ||
name: "MANUF_TOKEN", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: It may be good to clarify this a bit more. Is this an unlock token? If so, can we call it MANUF_UNLOCK_TOKEN
? The same applies for all the tokens below.
For cases where we have authorization tokens, it would be good to encode that in the name.
This will make the programming interface a bit more ergonomic.
read_lock: "CSR", | ||
key_sel: "NoKey", | ||
// This is a strike counter, hence we need to disable ECC integrity for this to work. | ||
// Integrity is handled at a higher level by SW as described below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integrity is handled at a higher level by SW as described below.
The description below is missing.
bkout_type: false, | ||
items: [ | ||
{ | ||
name: "FMC_KEY_MANIFEST_SVN", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multi-bit encoding for redundancy is recommended. So 32-bits may result in 16 SVN versions. We should check if this is sufficient.
Merge branch 'main' into user/ekabulut/lowRISC_FC_0115
e3e50ae
to
b7bc735
Compare
Regenerate partitions and assign the fuses (as documented here).