Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add, style, and use DictionaryCard #122

Merged
merged 3 commits into from
Feb 11, 2021
Merged

Add, style, and use DictionaryCard #122

merged 3 commits into from
Feb 11, 2021

Conversation

novellac
Copy link
Contributor

@novellac novellac commented Jan 23, 2021

This PR fixes...

This PR addresses #121

Note: The DictionaryCard doesn't look exactly like the Figma, but it supports some more cases that the Figma didn't cover. Will have @julietafb take a look and we can perhaps modify in a future PR.

What I did...

  • Added a DictionaryCard component
  • Styled DictionaryCard component ~ Figma

How to test...

  • Navigate to /dictionary
  • See that dictionary entries each appear with correct content
  • Check that links to add new perspective and add a definition lead to working Github files

I learned...

I added the last variant to the Tailwind config file - here's how. Keep this in mind if a Tailwind property is not working for you (this is what happened to me!). Read the docs to see if it must be added as a variant first.

@alliequintano
Copy link
Collaborator

Just took a peak at this and want to confirm a few observations:

  • overall the scale looks very large for me relative to the rest of the page, but not sure if this is the intended design (knowing that other elements on the page are unfinished). Hard to tell by looking at the figma because the page width looks different.. Would it be helpful to see design mockups for a variety of screen sizes? If Julieth is happy with this as is, i'm also happy to keep it! Just pointing it out.
    image

  • The "add a definition" and "add your perspective" links go to the corresponding github pages, which don't offer much instruction on what to do from that point. This might be okay if we are linking to the instructions elsewhere on the dictionary page? (I think we have something typed up in github already but I can't find it right now 😅 )

  • Lastly, a design comment that doesn't block this PR from being merged but curious what @julietafb thinks, I would love to be able to click on the whole dictionary entry "card" to view the entry page, rather than just clicking on the word. From the design as is, it's not obvious to me that I can click on it.

@Dreamy26 Dreamy26 merged commit b6e32f0 into pit Feb 11, 2021
Copy link
Contributor

@Dreamy26 Dreamy26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.. Thanks for adding more Style!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants