Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ByteStrings length immutable #17

Conversation

DanielSchiavini
Copy link

@DanielSchiavini DanielSchiavini commented Dec 11, 2023

What I did

Get rid of side effect comparing byte string sizes

How I did it

  • Remove set methods from _BytestringT
  • Always pass size to constructor when available
  • Add a clamp check during the runtime

How to verify it

  • Run the test tests/functional/codegen/test_interfaces.py::test_json_abi_bytes_clampers

Commit message

Get rid of side effect comparing byte string sizes

Description for the changelog

n/a

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@DanielSchiavini
Copy link
Author

Closing in favor of vyperlang#3379 - some of this PR might be incorporated by @charles-cooper in the future.

@DanielSchiavini DanielSchiavini deleted the feat/libraries branch December 18, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant