Skip to content
This repository has been archived by the owner on Mar 2, 2022. It is now read-only.

chore: fix typos in JVMChaos #58

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

STRRL
Copy link
Member

@STRRL STRRL commented Jul 29, 2021

Signed-off-by: STRRL [email protected]

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 29, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Jul 29, 2021
@ti-chi-bot
Copy link
Member

@STRRL: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[This PR modifies the files under the docs folder and requires the docs team to follow up on the PR.

/label docs
]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added docs This PR changes user documents. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 29, 2021
@netlify
Copy link

netlify bot commented Jul 29, 2021

✔️ Deploy Preview for chaos-mesh-website-zh-preview ready!

🔨 Explore the source changes: e51c4b9

🔍 Inspect the deploy log: https://app.netlify.com/sites/chaos-mesh-website-zh-preview/deploys/61020dccc65044000839dbe4

😎 Browse the preview: https://deploy-preview-58--chaos-mesh-website-zh-preview.netlify.app

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 29, 2021
@cwen0 cwen0 removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Jul 29, 2021
@cwen0
Copy link
Member

cwen0 commented Jul 29, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e51c4b9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 29, 2021
@ti-chi-bot ti-chi-bot merged commit 2874e05 into chaos-mesh:main Jul 29, 2021
@@ -21,7 +21,7 @@ JVMChaos 能向目标容器中的 JVM 注入故障,适用于任何使用 JVM

- Kubernetes 需要启用 Webhook 支持。
- 在为命名空间配置 MutatingAdmissionWebhook 之前已经存在 Pod,不会受到 JVMChaos 影响。
- 命名空间下的所有容器中的 JVM 都会在启动阶段加载 java agent,VMChaos 在被删除后也不会卸载 java agent。若考虑到 java agent 可能对程序行为或性能带来的影响,期望清理 java agnet,请将工作负载移出该命名空间。
- 命名空间下的所有容器中的 JVM 都会在启动阶段加载 java agent,JVMChaos 在被删除后也不会卸载 java agent。若考虑到 java agent 可能对程序行为或性能带来的影响,期望清理 java agnet,请将工作负载移出该命名空间。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.0 目录也需要更新

ti-chi-bot pushed a commit that referenced this pull request Jul 29, 2021
@qiancai qiancai added the translation/doing This PR’s assignee is translating this PR. label Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs This PR changes user documents. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/doing This PR’s assignee is translating this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants