Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge in multi species work from Q4 2024/experimental validator #1199

Merged
merged 21 commits into from
Jan 29, 2025

Conversation

joyceyan
Copy link
Contributor

@joyceyan joyceyan commented Jan 24, 2025

Reason for Change

https://czi.atlassian.net/browse/VC-1959

Changes

  • merges in all the commits from the q4-2024/experimental-validator branch into main, and rebases based on some changes that have occurred due to divergence
  • this relies on COG 1.4.1

Testing

  • tests were updated based on some divergences that occurred between main and q4-2024/experimental-validator
  • note that there are 6 tests that are marked as skipped for now. these are visium tests with the new species. i believe that this PR: feat: cellxgene-schema must update validation for X (Matrix Layers) for descendants of Visium #1133 introduced some new validation that our test fixtures need to account for.
  • since this PR is blocking further work for both of us, i think it makes sense to just merge this PR in as is, and patch those tests separately

Notes for Reviewer

@joyceyan joyceyan requested a review from ejmolinelli January 24, 2025 00:25
@joyceyan joyceyan force-pushed the q4-2024/experimental-validator branch from 1f4ce60 to 76375d6 Compare January 28, 2025 21:46
@joyceyan joyceyan changed the title feat: merge in multi species work from Q4 2024/experimental validator [WIP] feat: merge in multi species work from Q4 2024/experimental validator Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 89.73%. Comparing base (d67f0f2) to head (a11cbf3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1199      +/-   ##
==========================================
- Coverage   89.89%   89.73%   -0.17%     
==========================================
  Files          18       19       +1     
  Lines        2098     2143      +45     
==========================================
+ Hits         1886     1923      +37     
- Misses        212      220       +8     
Components Coverage Δ
cellxgene_schema_cli 90.64% <79.16%> (-0.27%) ⬇️
migration_assistant 91.26% <ø> (ø)
schema_bump_dry_run_genes 79.80% <100.00%> (ø)
schema_bump_dry_run_ontologies 99.53% <ø> (ø)

@joyceyan joyceyan merged commit ed383fb into main Jan 29, 2025
11 of 14 checks passed
@joyceyan joyceyan deleted the q4-2024/experimental-validator branch January 29, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants