Ledger rpc type changes #72
Conversation
| { | ||
| return Ok(()); | ||
| } | ||
| let mut response = Err(anyhow!("initial response value")); |
There was a problem hiding this comment.
I thought we might return the Err context here, as it was hard for me to debug why nodes were not becoming ready. But it is dependent on ledger_get_head_soft_confirmation_height, so we can revert this as well
There was a problem hiding this comment.
How valuable is the error from ledger_get_head_soft_confirmation_height here ?
There was a problem hiding this comment.
only if we change the endpoint again, but I don't think it is significant. It was hard for me to debug the type error here, so I thought I would include and see what you think
| @@ -44,14 +45,16 @@ impl Client { | |||
| Ok(self | |||
| .client | |||
| .request("ledger_getLastScannedL1Height", rpc_params![]) | |||
| .await?) | |||
| .await | |||
| .map(|v: U64| v.try_into().expect("U64 to u64 must succeed"))?) | |||
There was a problem hiding this comment.
What was the need for that and alloy_prinitives import ?
There was a problem hiding this comment.
ledger_getLastScannedL1Height's return type was changed to Result<U64> in the PR at the description
Updates the types in line with chainwayxyz/citrea#1743