-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Implements Hindsight Experience Replay #361
base: master
Are you sure you want to change the base?
Conversation
Here are a couple of differences from the original paper I noticed:
Please verify/be advised of the following:
|
chainerrl/agents/ddpg.py
Outdated
if self.obs_normalizer: | ||
batch['state'] = self.obs_normalizer(batch['state'], | ||
update=False) | ||
batch['next_state'] = self.obs_normalizer(batch['state'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be
batch['next_state'] = self.obs_normalizer(batch['state'], | |
batch['next_state'] = self.obs_normalizer(batch['next_state'], |
chainerrl/agents/ddpg.py
Outdated
@@ -251,6 +265,9 @@ def compute_actor_loss(self, batch): | |||
|
|||
# Since we want to maximize Q, loss is negation of Q | |||
loss = - F.sum(q) / batch_size | |||
if self.l2_action_penalty: | |||
loss += self.l2_action_penalty \ | |||
* F.square(onpolicy_actions) / batch_size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also include a F.sum term around the F.square?
No description provided.