fix: set alwayslink = True
#1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll wait until #1389 lands, since the test fixtures will be easier after that. |
auto-merge was automatically disabled
December 9, 2024 14:48
Pull request was converted to draft
brentleyjones
force-pushed
the
bj/fix-set-alwayslink-true
branch
from
d7076ad to
1e37651
Compare
brentleyjones
force-pushed
the
bj/fix-set-alwayslink-true
branch
from
1e37651 to
24be75c
Compare
brentleyjones
force-pushed
the
bj/fix-set-alwayslink-true
branch
from
24be75c to
498aaf7
Compare
|
Draft just because I want to land the other PR. Ready for review. |
cgrindel
approved these changes
Dec 16, 2024
This matches SPM’s behavior. It’s needed to create dynamic frameworks from rspm targets. Signed-off-by: Brentley Jones <[email protected]>
brentleyjones
force-pushed
the
bj/fix-set-alwayslink-true
branch
from
498aaf7 to
66dcee1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches SPM’s behavior. It’s needed to create dynamic frameworks from rspm targets.