Catch TypeError thrown by Safari if invalid entryType passed (#167)

Closes #166
census-instrumentation · Aug 22, 2019 · 2818dee · 2818dee
1 parent d1a0c11
commit 2818dee
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/packages/opencensus-web-instrumentation-perf/src/long-tasks-recorder.ts b/packages/opencensus-web-instrumentation-perf/src/long-tasks-recorder.ts
@@ -33,7 +33,13 @@ export function recordLongTasks() {
     const longTaskObserver = new windowWithLongTasks.PerformanceObserver(
       onLongTasks
     );
-    longTaskObserver.observe({ entryTypes: ['longtask'] });
+    try {
+      longTaskObserver.observe({ entryTypes: ['longtask'] });
+    } catch (err) {
+      //Safari (at least) throws a TypeError if entryTypes does not contain a valid entry.
+      //This can block further script execution. Gracefully handle this error and log instead.
+      console.error(err);
+    }
   }
   windowWithLongTasks.ocLt = [];
 }