Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option boldIsBright added #178

Merged

Conversation

M0M097
Copy link

@M0M097 M0M097 commented Jan 3, 2021

Added the option boldIsBright which is set to False by default. If set to True in termonad.hs this will lead to bright bold fonts.

This solves the issue with the unreadable blue text on dark background since blue text is almost always used together with bold fonts.

I would recommend to even set boldIsBright to True by default.

@cdepillabout
Copy link
Owner

cdepillabout commented Jan 4, 2021

Thanks for sending this.

I tried this out and this is what the colors look like:

My blue settings (from #176 (comment)) with boldIsBright set to False:

image

My blue settings (from #176 (comment)) with boldIsBright set to True:

image

The default Termonad palette with boldIsBright set to False:

image

The default Termonad palette with boldIsBright set to True (you can tell that this does make bold standard blue readable, unlike non-bold standard blue):

image


Here's the bash line to generate this output:

$ echo -e "\n\nnon-bold standard blue: \033[34mHello\033[0m\nnon-bold light blue:    \033[94mHello\033[0m\nbold standard blue:     \033[1;34mHello\033[0m\nbold light blue:        \033[1;94mHello\033[0m\n\n"

@cdepillabout
Copy link
Owner

I would recommend to even set boldIsBright to True by default.

I hesitate setting this to True by default.

If boldIsBright is False, the end user has 4 visually distinct font styles to use (standard, light, standard+bold, light+bold). But if boldIsBright is set to True, the end user only has 3 distinct font styles (standard, light, light+bold).

I think the cleaner solution is to just brighten up the standard and light blue colors, a la #177. Although I agree that we should be careful to make sure that the selected colors look alright in popular tui apps.

@cdepillabout cdepillabout merged commit 473c0ae into cdepillabout:master Jan 4, 2021
@cdepillabout
Copy link
Owner

Thanks for implementing this!

Released as v4.1.0.0:

https://hackage.haskell.org/package/termonad-4.1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants