refactoring #48
Merged
refactoring #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 185 120 -65
=========================================
- Hits 185 120 -65 ☔ View full report in Codecov by Sentry. |
ccoVeille
force-pushed
the
refactoring
branch
2 times, most recently
from
d2edce2 to
dfb2d31
Compare
Providing the value and error would be easier to test
One code to rule them all. This code is pretty similar to the one @ldemailly provided for https://github.com/fortio/safecast We worked at the same time on the same code, we came to distinct solutions. His one was better and simpler than mine, so now I'm simply switching to something highly inspired from his code. Co-Authored-By: Laurent Demailly <[email protected]>
ccoVeille
force-pushed
the
refactoring
branch
from
dfb2d31 to
aef85dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is pretty similar to the one @ldemailly provided for
https://github.com/fortio/safecast
We worked at the same time on the same code, we came to distinct solutions.
His one was better and simpler than mine, so now I'm simply switching to
something highly inspired from his code.