ci: also launch tests on i386 #47
Conversation
ccoVeille
force-pushed
the
i386
branch
2 times, most recently
from
4eeb629 to
2adbb05
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 185 185
=========================================
Hits 185 185 ☔ View full report in Codecov by Sentry. |
|
It's the first time I'm doing that @ldemailly what do you think? |
|
cc @jas4711 for a follow-up on Debian packaging |
Could you also take a look @mmorel-35 @yassinebenaid ? I'm curious about your feedbacks. |
Old 1.1.0 is confirmed failing on armhf and i386, both 32-bit archs: https://ci.debian.net/packages/g/golang-github-ccoveille-go-safecast/testing/armhf/54320394/ Likely also armel, but that arch is slow and hasn't run the build yet. I have packaged your i386 branch as a new Debian upload, and it builds fine on i386: https://salsa.debian.org/jas/golang-github-ccoveille-go-safecast/-/pipelines/762527 I am now uploading this to test on other archs, but hopefully it is fine. I would appreciate a new release eventually! /Simon |
@jas4711 sure, I'll release once merged |
|
This has some problems even on 64-bit platforms, check test results: https://tracker.debian.org/pkg/golang-github-ccoveille-go-safecast This uses dd8172d Good thing it now works on i386 :) For example arm64 -- https://ci.debian.net/packages/g/golang-github-ccoveille-go-safecast/testing/arm64/54342388/ Could you take a look at the logs? Seems like the float changes introduced some bugs, before (v1.10.0) it passed on all 64-bit platforms. |
Fixes #6 Fixes #46 The tests in conversion_test.go are the ones that are not architecture dependent The tests in conversion_64bit_test.go complete them for 64-bit systems The tests in examples_test.go are the ones that are not architecture dependent The tests in examples_32bit_test.go are for 32-bit systems The tests in examples_64bit_test.go are for 64-bit systems The architecture dependent file covers the fact, you can reach a higher value with int and uint on 64-bit systems, but you will get a compile error on 32-bit. The error message is different on 32-bit and 64-bit systems The max is 9223372036854775807 on 64-bit and 2147483647 on 32-bit
I've uploaded 1.1.0+git20241114-1 to Debian and results should arrive here within the next day or so: https://tracker.debian.org/pkg/golang-github-ccoveille-go-safecast Please ignore the results for 20241113, they are for the old version. |
|
The build looks good now. A new release would be great! Thank you. |
@jas4711 1.2.0 is out |
|
FWIW, 1.2.0 has now been built fine on all architectures, so I can confirm that this is solved. |
Fixes #6
Fixes #46