better error messages #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only uint64 and uint was working as expected Fixes #23
ldemailly
reviewed
Sep 10, 2024
ccoVeille
force-pushed
the
better-error
branch
from
de17f87 to
e316712
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 3 +1
Lines 90 114 +24
=========================================
+ Hits 90 114 +24 ☔ View full report in Codecov by Sentry. |
ccoVeille
force-pushed
the
better-error
branch
from
e316712 to
19db706
Compare
|
mentioned on slack that math.MinInt32 for instance shouldn't be rejected but from doc and error message point if view lgtm |
ccoVeille
force-pushed
the
better-error
branch
from
19db706 to
ba53092
Compare
ccoVeille
force-pushed
the
better-error
branch
from
ba53092 to
618c455
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15