Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flask Backend Module for WebCAS #8

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jayanthchandra
Copy link

Hey,

As mentioned on Readme, the module is written in Flask.This is the base module which i could write, the ui part could be done using jinja templates. If i have missed anything, let me know :)

If this development is already done through, then you close this request.

Copy link
Contributor

@pnijhara pnijhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please see my comments and make those changes.

run.py Outdated
if __name__ == '__main__':
app.run()

###############################################################################
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these!

@@ -0,0 +1,82 @@

# Imports
##########
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary octothorps

###############################################################################


# Pre/Post Request Processing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to write proper comments then replace these octothorps with proper comments.

@pnijhara
Copy link
Contributor

@jayanthchandra jinja sounds good to me!
@akram-mohammed, please review it again.

@pnijhara
Copy link
Contributor

LGTM! lets wait for @akram-mohammed's respose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants