-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flask Backend Module for WebCAS #8
base: master
Are you sure you want to change the base?
Flask Backend Module for WebCAS #8
Conversation
…/webSCAS into feat/flaskBackend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please see my comments and make those changes.
run.py
Outdated
if __name__ == '__main__': | ||
app.run() | ||
|
||
############################################################################### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these!
scasBackend/__init__.py
Outdated
@@ -0,0 +1,82 @@ | |||
|
|||
# Imports | |||
########## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unnecessary octothorps
scasBackend/__init__.py
Outdated
############################################################################### | ||
|
||
|
||
# Pre/Post Request Processing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to write proper comments then replace these octothorps with proper comments.
@jayanthchandra jinja sounds good to me! |
LGTM! lets wait for @akram-mohammed's respose. |
Hey,
As mentioned on Readme, the module is written in Flask.This is the base module which i could write, the ui part could be done using jinja templates. If i have missed anything, let me know :)
If this development is already done through, then you close this request.