Merge pull request #3074 from catchpoint/AZU186098

Limit Web Page Script to 25 steps
catchpoint · Jul 15, 2024 · eaae4dc · eaae4dc
2 parents b7d6765 + 1acbbb4
commit eaae4dc
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 8 deletions.
diff --git a/docker/local/wptconfig/settings.ini b/docker/local/wptconfig/settings.ini
@@ -73,7 +73,7 @@ allowNonFQDN=1
 enable_agent_processing=1
 
 ; Sets the maximum number of navigates in a script
-maxNavigateCount=20
+maxNavigateCount=25
 
 ; Selects the metric to use for the median run (defaults to loadTime)
 medianMetric=SpeedIndex

diff --git a/tests/fixtures/settings.ini b/tests/fixtures/settings.ini
@@ -91,7 +91,7 @@ allowNonFQDN=0
 enable_agent_processing=1
 
 ; Sets the maximum number of navigates in a script
-maxNavigateCount=20
+maxNavigateCount=25
 
 ; Selects the metric to use for the median run (defaults to loadTime)
 ; medianMetric=SpeedIndex
@@ -318,4 +318,4 @@ paid_priority=0
 user_priority=2
 api_priority=5
 bulk_priority=8
-friendly_urls=1
+friendly_urls=1
diff --git a/www/runtest.php b/www/runtest.php
@@ -2072,10 +2072,7 @@ function ValidateScript(&$script, &$error)
 
         $test['navigateCount'] = $navigateCount;
 
-        $maxNavigateCount = Util::getSetting("maxNavigateCount");
-        if (!$maxNavigateCount) {
-            $maxNavigateCount = 20;
-        }
+        $maxNavigateCount = Util::getSetting("maxNavigateCount", 25);
 
         if (!$ok) {
             $error = "Invalid Script (make sure there is at least one navigate command and that the commands are tab-delimited).  Please contact us if you need help with your test script.";

diff --git a/www/settings/settings.ini.sample b/www/settings/settings.ini.sample
@@ -91,7 +91,7 @@ allowNonFQDN=0
 enable_agent_processing=1
 
 ; Sets the maximum number of navigates in a script
-maxNavigateCount=20
+maxNavigateCount=25
 
 ; Selects the metric to use for the median run (defaults to loadTime)
 ; medianMetric=SpeedIndex