Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Q1 2025 EIA 930 data #4054

Merged
merged 12 commits into from
Feb 12, 2025
Merged

Update Q1 2025 EIA 930 data #4054

merged 12 commits into from
Feb 12, 2025

Conversation

krivard
Copy link
Contributor

@krivard krivard commented Feb 10, 2025

Overview

Closes #4040.

What did you change?

  • Updated DOI
  • Added 30 new columns in balance.csv - but these fit into the existing net_generation scheme so we don't need new PUDL DB columns to match
  • Depopulated 9 removed columns in balance.csv
  • Sorted balance.csv in alphabetical order (sorry) (not all that sorry)
  • Error messaging on csv parse failures
  • New energy sources in enums.py
  • Updated MultiIndex generation to not be confused by underscores in energy source names

Documentation

Make sure to update relevant aspects of the documentation.

Tasks

Preview Give feedback

Testing

How did you make sure this worked? How can a reviewer verify this?

To-do list

Preview Give feedback

@krivard krivard linked an issue Feb 10, 2025 that may be closed by this pull request
@krivard krivard self-assigned this Feb 10, 2025
Copy link
Member

@cmgosnell cmgosnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor docs requests but this looks pretty great!

Comment on lines 67 to 72
netgen_by_source.columns = pd.MultiIndex.from_tuples(
[x.split("_") for x in netgen_by_source.columns],
# Some of our energy sources have multiple terms in them, so we rsplit on
# a maximum of one underscore to ensure we get the exact two results we need:
[x.rsplit("_", maxsplit=1) for x in netgen_by_source.columns],
names=["generation_energy_source", None],
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great!

@krivard krivard marked this pull request as ready for review February 12, 2025 15:03
@krivard krivard force-pushed the eia-930-q1-2025-update branch from 0518d17 to 70174c8 Compare February 12, 2025 17:44
@krivard krivard requested a review from cmgosnell February 12, 2025 17:44
Copy link
Member

@cmgosnell cmgosnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cmgosnell
Copy link
Member

oh lol... now that a few more things got merged in before this you'll need to deal with merge conflicts but those should be straightforward

@krivard krivard added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 49b01b2 Feb 12, 2025
19 checks passed
@krivard krivard deleted the eia-930-q1-2025-update branch February 12, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

EIA 930 Q1 2025 Update
2 participants