-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eia860m eia923 q1 2025 #4047
Eia860m eia923 q1 2025 #4047
Conversation
@@ -1552,6 +1552,7 @@ | |||
"rr": "RR", | |||
"pl": "PL", | |||
"rv": "RV", | |||
"RT": "TR", # This is based on a guess. No definitive proof. Culprit is plant_id_eia 3935 in October 2024 in the coalmine table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to see what the other rows from the same coalmine listed as the primary transportation method to see if there was a clear fix here; sadly there was not. Entries from older years say "RV" and newer years say "TR". I chose TR because it's "RT" backwards....also it only affects two entires so it's a very minimal issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me!! I left some suggestions on the release notes and on the min/max rows.
Co-authored-by: Christina Gosnell <[email protected]>
…cooperative/pudl into eia860m-eia923-q1-2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Overview
Closes #4038
What problem does this address?
Adds new monthly data from EIA860m and EIA923
What did you change?
Documentation
Make sure to update relevant aspects of the documentation.
Tasks
Testing
How did you make sure this worked? How can a reviewer verify this?
To-do list