Only generate alphanumeric entity IDs in test #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers seem to break groupby.
zaneselvans
approved these changes
Oct 31, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #2993 +/- ##
======================================
Coverage 88.6% 88.6%
======================================
Files 91 91
Lines 10854 10991 +137
======================================
+ Hits 9618 9749 +131
- Misses 1236 1242 +6
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some non-printable characters seem to break Pandas groupby, which was causing the test to mis-identify which contexts were worth making assertions about.