Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gimbal yaw and pitch command ros2 message #190

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add gimbal yaw and pitch command ros2 message #190

wants to merge 2 commits into from

Conversation

caomuqing
Copy link
Member

@caomuqing caomuqing commented Jan 16, 2025 •
edited by andrewjong
Loading

@andrewjong
Copy link
Member

andrewjong commented Jan 16, 2025 •
edited
Loading

Thanks very much for your PR!
A few things that we also went over in person before we merge

  • make sure to update the docs
  • add a video of expected behavior
  • convert the gimbal package into an Omniverse extension that provides an Omnigraph node. then we can feed in the robot name and make sure the gimbal uses the correct topics
  • please also add launching to the robot launch files
  • adjust the scene units of your gimbal prim to be in meters
  • can you also rebase into a single commit?

@caomuqing
Copy link
Member Author

video recording of the feature:
https://drive.google.com/file/d/12S6eLNJUrKxMMlgacYSYCnynlDa4BSgR/view?usp=sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caomuqing @andrewjong @tharp789