Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SignedBlock to BlockWithSignatures #401

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Rename SignedBlock to BlockWithSignatures #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6009b36
rename all occurences of 'signed block' to 'block with signatures'
igor-casper Jan 30, 2025
11c7cc3
fmt
igor-casper Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 64 additions & 34 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions rpc_sidecar/src/node_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ use casper_types::{
bytesrepr::{self, FromBytes, ToBytes},
contracts::ContractPackage,
system::auction::DelegatorKind,
AvailableBlockRange, BlockHash, BlockHeader, BlockIdentifier, ChainspecRawBytes, Digest,
GlobalStateIdentifier, Key, KeyTag, Package, Peers, ProtocolVersion, PublicKey, SignedBlock,
StoredValue, Transaction, TransactionHash, Transfer,
AvailableBlockRange, BlockHash, BlockHeader, BlockIdentifier, BlockWithSignatures,
ChainspecRawBytes, Digest, GlobalStateIdentifier, Key, KeyTag, Package, Peers, ProtocolVersion,
PublicKey, StoredValue, Transaction, TransactionHash, Transfer,
};
use std::{
fmt::{self, Display, Formatter},
Expand Down Expand Up @@ -194,14 +194,14 @@ pub trait NodeClient: Send + Sync {
parse_response::<BlockHeader>(&resp.into())
}

async fn read_signed_block(
async fn read_block_with_signatures(
&self,
block_identifier: Option<BlockIdentifier>,
) -> Result<Option<SignedBlock>, Error> {
) -> Result<Option<BlockWithSignatures>, Error> {
let resp = self
.read_info(InformationRequest::SignedBlock(block_identifier))
.read_info(InformationRequest::BlockWithSignatures(block_identifier))
.await?;
parse_response::<SignedBlock>(&resp.into())
parse_response::<BlockWithSignatures>(&resp.into())
}

async fn read_transaction_with_execution_info(
Expand Down
Loading
Loading