Aligning timeouts to reflect real-world scenarios #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zajko
requested review from
wojcik91,
igor-casper,
darthsiroftardis and
EdHastingsCasperAssociation
…used properties; removing `request_limit` and the logic attached to that since we don't actually handle multiple in-flight requests; Removing the possibility to define "infinite" as a valid retry amount in node client connector since it can lead to deadlocks
zajko
force-pushed
the
aligning_timeouts_various_fixes
branch
from
c89da6a to
8fa9b3b
Compare
wojcik91
approved these changes
Jan 29, 2025
rpc_sidecar/src/node_client.rs
Outdated
| @@ -1059,6 +1069,7 @@ impl FramedNodeClient { | |||
| .await | |||
| .map_err(|_| Error::RequestFailed("timeout".to_owned()))? | |||
There was a problem hiding this comment.
I'd log the actual error here for easier debugging.
There was a problem hiding this comment.
I don't think it's very informative, although I see that register_timeout is in the wrong place
…o gain retries and id-checks
darthsiroftardis
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request_limitand the logic attached to that since we don't actually handle multiple in-flight requests to binary-portRpcServerConfigTarget,NodeClientConfigTarget,ExponentialBackoffConfigTargetandMaxAttemptsTargetsince we don't need custom code for deserialization of the config file.MAX_COMPONENT_STARTUP_TIMEOUT_SECSguard in case one of the components hangs on startup