Refreshing casper-node dependency, refactoring tests for 'chain_get_e… #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zajko
force-pushed
the
seniorage_allocation_refresh
branch
2 times, most recently
from
738f9d0 to
c2f3d2e
Compare
…ra_info_by_switch_block'
zajko
force-pushed
the
seniorage_allocation_refresh
branch
from
c2f3d2e to
6dee528
Compare
wojcik91
approved these changes
Jan 24, 2025
mpapierski
approved these changes
Jan 24, 2025
Comment on lines
949
to
950
| let ends_with_id = Regex::new(r"\nid:\d*$").unwrap(); | ||
| let starts_with_data = Regex::new(r"^data:").unwrap(); |
There was a problem hiding this comment.
Since you're at it let's make these static ENDS_WITH_ID_REGEX: Lazy<Regex> = Lazy::new(...) - I'm not sure if regex crate memorizes already compiled regexes internally (why would they?). Compile times are non-trivial, so paying the cost once is better. (https://docs.rs/regex/latest/regex/#avoid-re-compiling-regexes-especially-in-a-loop)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ra_info_by_switch_block'