Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EntityAddr instead of AddressableEntityHash #275

Merged

Conversation

jacek-casper
Copy link

@jacek-casper jacek-casper commented Apr 9, 2024

The initial code was written before EntityAddr was introduced, so we didn't use it, but now that EntityAddr exists, it should be used here instead for consistency with other code (like for example GetDictionaryItem).

Depends on casper-network/casper-node#4653.

@jacek-casper jacek-casper requested a review from zajko April 10, 2024 17:11
Copy link

@rafal-ch rafal-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jacek-casper jacek-casper merged commit c7988fa into casper-network:feat-2.0 Apr 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants