Changing internal structure of EventListener so it can be unit tested #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zajko
force-pushed
the
code_debt_removal_pt_3
branch
4 times, most recently
from
afdd297 to
689f551
Compare
zajko
force-pushed
the
code_debt_removal_pt_3
branch
3 times, most recently
from
2b015c5 to
ae1a4b9
Compare
zacshowa
approved these changes
Dec 15, 2023
listener/src/connections_builder.rs
Outdated
| let guard = last_event_id_for_filter.lock().await; | ||
|
|
||
| for filter in filters { | ||
| let mut start_from_event_id = guard.get(&filter).copied(); |
There was a problem hiding this comment.
I believe for this situation specifically you could handle the case where guard.get(&filter) is none by changing this line to
let mut start_from_event_id = guard.get(&filter).copied().or(Some(0));
I believe they should be functionally equivalent, so I think whichever you think is more readable would be fine.
zajko
force-pushed
the
code_debt_removal_pt_3
branch
from
ae1a4b9 to
aef31dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle_rejectionandstream_to_clientgiven_sse_connection_when_no_data_should_fail()unit test - it would hang once every 40-60 runs due to a race condition in setting up the mock sse server