Introduced handling of Authorization http header. For now "Bearer" to… #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ken authentication is being handled. For now tokens and usernames are defined in the config file of sidecar
zajko
force-pushed
the
token_based_authorization
branch
from
def2a55 to
2c613a1
Compare
zacshowa
approved these changes
Nov 20, 2023
Comment on lines
+570
to
+585
| async fn fetch_data(port: u16, relative_path: &str, maybe_authorization: Option<&str>) -> Response { | ||
| let request_url = format!( | ||
| "http://{}:{}/{}", | ||
| Ipv4Addr::UNSPECIFIED, | ||
| port, | ||
| relative_path | ||
| ); | ||
| let mut builder = reqwest::Client::new().get(request_url.clone()); | ||
| if let Some(authorization) = maybe_authorization { | ||
| builder = builder.header("Authorization", authorization) | ||
| } | ||
| builder | ||
| .send() | ||
| .await | ||
| .unwrap_or_else(|_| panic!("Error requesting endpoint {}", request_url)) | ||
| } |
There was a problem hiding this comment.
Is it possible that in the future creating the clients like this for the tests could cause issues by attempting to initiate too many connections to the sidecar too quickly? If that isn't the case, I would say this is fine, there probably isn't a need to hyperoptimize the tests.
There was a problem hiding this comment.
Each test spins up it's own instance of sidecar on a random port so it's not an issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ken authentication is being handled. For now tokens and usernames are defined in the config file of sidecar