Use a Sass variable for default font #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Bisaloo - please could you merge in main/rebase this PR and we can move forward with it? |
To facilitate update and fork styling
Bisaloo
force-pushed
the
font-variable
branch
from
c9ce6f3 to
d562d6d
Compare
|
LGTM! Thank you @Bisaloo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to facilitate theming in varnish forks.
Currently, forks that want to set their own fonts need to edit numerous files and it takes a lot of maintainance work to fix the various git conflicts that arise as a result when pulling from upstream.
By setting the font once as a Sass variable, this should reduce the difficulty of:
I'm definitely not a CSS or Sass expert but I have tested this locally and it works as expected as far as I can tell.